Repository navigation
chore: add css-containers and css-light-dark skills - #211
Merged
Merged
Conversation
Move the light and dark theme rules out of the ui-component skill into css-light-dark, which also shows how to keep `light-dark()` native through Lightning CSS, and point ui-component to both new skills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new skills, in the shape of
css-mixin.css-containersNamed container queries in a CSS Modules codebase:
containers.module.css, the only place that declarescontainer:. The element that is the container takes the class from its markup, and parts query the name with@container.cssModules: { container: false }..cardBodymakescard-body).container-type.css-light-darkThe light and dark theme rules move here out of
ui-component: color tokens aslight-dark()pairs on:rootwithcolor-scheme, a forced scheme for a theme switch or a preview toolbar, and a theme class with its own palette for widgets on someone else's page. It adds the Lightning CSS setting that keepslight-dark()native in the build (exclude: Features.LightDark), and a site's own theme switch for server-rendered pages: the choice kept inlocalStorage, set on the root by an inline script in the head before the stylesheets arrive, followed across tabs, with pictures drawn for one theme hidden bydata-theme.ui-componentdrops that section; the README lists both new skills.🤖 Generated with Claude Code