Repository navigation
Keep Search button clear of mobile filter links - #313
Merged
Merged
Conversation
1 task
Owner
|
Thanks, Steph, this is a clean fix for #312. Checked locally with this branch applied (
Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312
The Search button now hides while search or filters are on screen, so it doesn't cover the links on mobile. It comes back after scrolling past the filters.
Checked at 390×844 and 1280×800, including returning to search and opening/closing the filters.
npm run checkpasses.Type
Checklist
npm test && npm run validatepasses locally (the fullnpm run checkalso passes).The catalog, stack, and licence checks don't apply here. Only the button visibility changed.