Skip to content

package dokeili - #364

Open
SharonStrats wants to merge 1 commit into
stagingfrom
package-dokeili
Open

SharonStrats wants to merge 1 commit into
stagingfrom
package-dokeili

Conversation

@SharonStrats

Copy link
Copy Markdown
Contributor

No description provided.

@SharonStrats
SharonStrats requested review from bourgeoa and a balanced review from Copilot November 19, 2026 11:50
@SharonStrats SharonStrats self-assigned this Nov 19, 2026
@SharonStrats SharonStrats added the bug Something isn't working label Nov 19, 2026
@SharonStrats SharonStrats moved this to In review in SolidOS NLNet UI Nov 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The pinned solidos-toolkit override implementation is unavailable locally, and source tests cannot establish generated-artifact CJS/ESM loading or browser compatibility of remaining transitive imports.

No open issues 🎉

What changed in this PR

This PR adjusts solid-logic’s build to bundle Dokieli’s ACL package and selected dependencies, avoiding direct CommonJS loading of Dokieli’s ESM-only entry.

Changes:

  • Adds a bundling allowlist for Dokieli, RDF/JS packages, and N3 while keeping other bare package imports external.
  • Documents the intended ESM and CommonJS bundling behavior.
File Description
vite.config.mts Customizes dependency externalization to bundle the selected ACL dependencies.
README.md Explains the bundling behavior and its CommonJS compatibility purpose.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants