Skip to content

test(cli): run full suite across Windows shells - #1736

Merged
John-David Dalton (jdalton) merged 1 commit into
v1.xfrom
test/windows-powershell-full-suite
Nov 18, 2026
Merged

John-David Dalton (jdalton) merged 1 commit into
v1.xfrom
test/windows-powershell-full-suite

Conversation

@jdalton

@jdalton John-David Dalton (jdalton) commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Run pnpm test-ci on Windows 2022 under Bash and PowerShell. The PowerShell job also verifies Bazel Maven manifests.

@cursor

cursor Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to CI workflow configuration and .gitignore; no application or auth logic is modified.

Overview
Consolidates Windows validation into the main CI test job and removes the standalone .github/workflows/bazel-windows.yml workflow (.gitignore no longer whitelists that file).

The test matrix now uses explicit include rows for Linux Node 22/24/26 (bash, 15 min) and Windows Server 2022 with Node 24.14.1 under bash and pwsh (90 min), with job names showing OS, Node, and shell.

Windows-specific setup in ci.yml adds a checksum-verified Node zip install on pwsh, shell-conditioned dependency install and pnpm test-ci (full unit + integration vs the old Windows job’s narrower vitest list). The PowerShell matrix leg also installs pinned Python/Java/Bazelisk, packs and installs the CLI, and runs the Bazel Maven native e2e (bazel-native.e2e.test.mts) with SOCKET_BAZEL_INTEGRATION=1, matching what the deleted workflow did for Maven on Windows.

Reviewed by Cursor Bugbot for commit 9fde916. Configure here.

@jdalton John-David Dalton (jdalton) changed the title Run the full test suite on Windows shells test(cli): run full suite across Windows shells Nov 18, 2026
@jdalton
John-David Dalton (jdalton) force-pushed the test/windows-powershell-full-suite branch 14 times, most recently from 57b3779 to 058de08 Compare November 18, 2026 13:56
@jdalton
John-David Dalton (jdalton) force-pushed the test/windows-powershell-full-suite branch from 058de08 to 1e60ae8 Compare November 18, 2026 14:09

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a big portion of this is over my head.

I think maybe the description could be a bit understated, looks like there's some behaviour changes to a few tests. I'm going to guess it's due to different behaviour on Windows being required, but my approval here doesn't carry much weight.

@jdalton
John-David Dalton (jdalton) merged commit 0088e3c into v1.x Nov 18, 2026
25 checks passed
@jdalton
John-David Dalton (jdalton) deleted the test/windows-powershell-full-suite branch November 18, 2026 14:56
@jdalton

Copy link
Copy Markdown
Contributor Author

Georgescu Rares Daniel (@RaresGeo)
Thanks for the careful review. You’re right that the description understated the scope. The main change is to run the full test suite on Windows under both Bash and PowerShell, with the Bazel Maven check in the PowerShell job. This replaces the separate Bazel Windows workflow.

The test behavior changes are platform-specific fixes for Windows shell and subprocess differences; they’re not intended to change CLI behavior. The diff also includes supporting Bazel path and setup-script cleanup. I should have called that out in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants