Repository navigation
test(cli): run full suite across Windows shells - #1736
Conversation
PR SummaryLow Risk Overview The test matrix now uses explicit Windows-specific setup in Reviewed by Cursor Bugbot for commit 9fde916. Configure here. |
57b3779 to
058de08
Compare
058de08 to
1e60ae8
Compare
Georgescu Rares Daniel (RaresGeo)
left a comment
There was a problem hiding this comment.
LGTM but a big portion of this is over my head.
I think maybe the description could be a bit understated, looks like there's some behaviour changes to a few tests. I'm going to guess it's due to different behaviour on Windows being required, but my approval here doesn't carry much weight.
|
Georgescu Rares Daniel (@RaresGeo) The test behavior changes are platform-specific fixes for Windows shell and subprocess differences; they’re not intended to change CLI behavior. The diff also includes supporting Bazel path and setup-script cleanup. I should have called that out in the description. |
Run
pnpm test-cion Windows 2022 under Bash and PowerShell. The PowerShell job also verifies Bazel Maven manifests.