Skip to content

refactor(runtime): inline registry helpers and update dependencies - #1735

Open
John-David Dalton (jdalton) wants to merge 1 commit into
v1.xfrom
refactor/inline-registry-v1x
Open

John-David Dalton (jdalton) wants to merge 1 commit into
v1.xfrom
refactor/inline-registry-v1x

Conversation

@jdalton

@jdalton John-David Dalton (jdalton) commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Remove @socketsecurity/registry from the CLI and build tooling while keeping the full Package URL API.

Changes

  • Inline the registry helpers used by CLI commands, scripts, and builds; remove the registry dependency and patch.
  • Use @socketregistry/packageurl-js 1.7.0 directly and retain the pnpm override used by cdxgen.
  • Update Socket SDK to 4.3.0, Socket Patch to 5.1.0, Coana CLI to 15.15.1, and cdxgen to 12.9.2.
  • Update Vite to 8.3.8 and Vitest to 5.1.1; enable pnpm's global virtual store and declare a missing @actions/cache runtime dependency.
  • Move pnpm settings into pnpm-workspace.yaml and update the pnpm 12 lockfile and SEA notices.
  • Refresh terminal snapshots and package-matrix checks; fix Windows pnpm path validation and enforce LF for packaged CLI shebangs.
  • Update CI to pnpm 12.21.0, npm 12.2.3, Node 26.13.0, and SFW 1.16.0 with matching platform checksums.

Local verification

Frozen install, unit tests, type checks, lint, cache action tests, CLI and SEA builds, package URL tests, Coana snapshot updates, and native test snapshots pass.

@cursor

cursor Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Wide import and build-pipeline changes touch core CLI infrastructure (spawn, config/package JSON, prompts, dist layout), though behavior is intended to stay parity with the removed package.

Overview
Drops @socketsecurity/registry and @socketregistry/packageurl-js as npm dependencies by vendoring the helpers the CLI actually used into scripts/utils/registry-helpers.js (build scripts) and new src/utils/* modules (debug, logger, spawn, prompts, fs, arrays, env, etc.), then rewiring imports across commands and tests.

Build and distribution now bundle those helpers into dist (dedicated Rollup chunks for registry constants, env, spawn-sync, spinner) instead of copying the registry into external/; @socketsecurity/registry is removed from EXTERNAL_PACKAGES. bin/cli.js loads spawn from dist/utils.js. scripts/constants.js no longer extends the registry constants object—it defines env/path constants locally and inlines common file-name constants.

Dependencies and licensing: @inquirer/* is added for interactive prompts; supports-color is optional. LICENSE gains third-party notices for the inlined registry code and related snippets. The registry pnpm patch file is removed; tiny-updater patch is updated to drop the registry dependency.

Housekeeping: CLAUDE.md import/spawn guidance points at local utils; is-object-object is renamed to is-record in .gitignore; eslint.config.js stops importing registry constants.

Reviewed by Cursor Bugbot for commit 1f51eb5. Configure here.

@socket-security-staging

This comment was marked as duplicate.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1f51eb5. Configure here.

Comment thread bin/cli.js Resolved
Comment thread scripts/utils/registry-helpers.js Resolved
Comment thread package.json Resolved
@jdalton
John-David Dalton (jdalton) force-pushed the refactor/inline-registry-v1x branch 5 times, most recently from 5cc0f8c to e611959 Compare November 18, 2026 03:21
@jdalton John-David Dalton (jdalton) changed the title refactor(runtime): inline registry helpers refactor(runtime): inline registry helpers and update dependencies Nov 18, 2026
@socket-security-staging

This comment was marked as resolved.

@jdalton

Copy link
Copy Markdown
Contributor Author

@SocketSecurity-Staging ignore-all

@jdalton
John-David Dalton (jdalton) force-pushed the refactor/inline-registry-v1x branch 12 times, most recently from d2c23b4 to 48b3103 Compare November 18, 2026 16:17

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review found a behavior regression in the new object helper.

Comment thread src/utils/objects.mts Resolved
@jdalton
John-David Dalton (jdalton) force-pushed the refactor/inline-registry-v1x branch 2 times, most recently from d05cdcb to 0250b2f Compare November 18, 2026 16:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant