Repository navigation
Conversation
Semver-compatible lockfile updates only: flatted, lodash, tar and ws. undici is bumped where the dependency range allows it; the copy pinned by discord.js is handled separately.
discord.js pins undici to an exact version, so the undici advisories can only be fixed by moving to a discord.js release that depends on a patched undici. 14.28.1 stays on the same major version.
Runs npm audit against the production dependencies in package-lock.json every Monday and on demand, and fails on HIGH or CRITICAL advisories that are not listed in .github/audit-ignore.json.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
A
Dependency auditGitHub Actions workflow (.github/workflows/audit.yml). It runs every Monday at 06:17 UTC and on demand (workflow_dispatch). It readspackage-lock.jsononly (no install, no secrets,contents: read), runsnpm audit --omit=devand fails on HIGH or CRITICAL advisories in production dependencies. Advisories that have no patched version can be listed in.github/audit-ignore.json(currently empty). It is intentionally not a pull request check.Dependency fixes (separate commits)
The audit found 12 HIGH/CRITICAL advisories on main before this PR (flatted, lodash, tar, ws, undici).
discord.js14.26.4 to 14.28.1 (same major, exact pin in package.json): discord.js pins undici, and 14.28.1 is the first release depending on a patched undici. Drop this commit if you prefer to handle it separately, but the workflow will then stay red on the undici advisories.After these commits no HIGH/CRITICAL advisories remain (3 lower-severity ones are left, not gated).
Verification
npm run test:unit: 229 suites passed, 2608 tests passed, 2 skipped, same as main.npx eslint ./reports the same number of errors as main (the repo already has many pre-existing lint errors); the new script adds none.