Repository navigation
Conversation
5c7d0a2 to
eed1915
Compare
renkun-ken
left a comment
There was a problem hiding this comment.
I ran the discovery and backend suites and both real-arf adoption tests on macOS with arf 0.7.2. All 49 passed, including evaluation after the agent closed.
I’m requesting changes to the workspace-folder setting, the CLI deadline, and the handling of arf restarts during discovery and bootstrap. The inline comments include the observed behavior and suggested regression coverage.
eed1915 to
0d9523e
Compare
renkun-ken
left a comment
There was a problem hiding this comment.
The same-PID restart check and bootstrap over the verified attach connection both passed on 0d9523e. The user guide now covers private session directories, and discovery returned at five seconds with a SIGTERM-handling wrapper. All 60 focused local tests passed on macOS with arf 0.7.2, including the two real adoption tests.
I also ran Connect in a two-folder VS Code 1.145.2 workspace. With a file open in A or B, it ran that folder’s configured executable. The manifest assertion covers the scope change. I’m requesting fixes for the first-folder setting when Connect is launched from an empty or untitled editor and for the pipes left open after a wrapper times out. I’ve included the observed results inline, along with a small developer README correction.
0d9523e to
04ced2c
Compare
r.interactive.arfPath had no scope, so VS Code read it per window and every workspace folder used one value, both for listing running arf sessions and for new sessions. It is now machine-overridable, so a folder can set its own arf, which listing and new sessions resolve from the folder they are for. Without an editor in a workspace folder, as when Connect runs from an empty or untitled editor, the first folder's setting applies, as its directory does.
e544344 to
026b0e3
Compare
r.interactive.arfPathhad no scope, so VS Code read it per window and every workspace folder used one value, both for listing running arf sessions and for new sessions.r.interactive.arfPathismachine-overridable, so each workspace folder can set its own arf. Listing and new sessions resolve it from the workspace folder they are for, as they do its directory. Without an editor in a workspace folder, as when Connect runs from an empty or untitled editor, the first folder's setting applies.