Skip to content

feat(interactive): let each workspace folder set its own arf - #1988

Open
eitsupi wants to merge 1 commit into
fix/interactive-adopted-stopfrom
feat/interactive-arf-ipc-discovery
Open

eitsupi wants to merge 1 commit into
fix/interactive-adopted-stopfrom
feat/interactive-arf-ipc-discovery

Conversation

@eitsupi

@eitsupi eitsupi commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

r.interactive.arfPath had no scope, so VS Code read it per window and every workspace folder used one value, both for listing running arf sessions and for new sessions.

  • r.interactive.arfPath is machine-overridable, so each workspace folder can set its own arf. Listing and new sessions resolve it from the workspace folder they are for, as they do its directory. Without an editor in a workspace folder, as when Connect runs from an empty or untitled editor, the first folder's setting applies.
  • The setting's description says to set it in the remote or folder settings on a remote host.

@eitsupi
eitsupi requested a review from renkun-ken November 22, 2026 02:02
@eitsupi
eitsupi marked this pull request as ready for review November 22, 2026 02:02
@eitsupi
eitsupi force-pushed the feat/interactive-arf-ipc-discovery branch from 5c7d0a2 to eed1915 Compare November 22, 2026 02:20
@eitsupi
eitsupi changed the base branch from main to fix/interactive-adopted-stop November 22, 2026 02:20
@eitsupi
eitsupi added this pull request to stack #1989 November 22, 2026 02:20

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the discovery and backend suites and both real-arf adoption tests on macOS with arf 0.7.2. All 49 passed, including evaluation after the agent closed.

I’m requesting changes to the workspace-folder setting, the CLI deadline, and the handling of arf restarts during discovery and bootstrap. The inline comments include the observed behavior and suggested regression coverage.

Comment thread package.json Resolved
Comment thread src/interactive/arf.ts Resolved
Comment thread src/interactive/arf.ts Resolved
Comment thread src/interactive/backends/arf.ts Resolved
Comment thread website/docs/features/r-interactive.md Resolved
@eitsupi eitsupi changed the title feat(interactive): list arf sessions with the arf CLI refactor(interactive): list arf sessions with the arf CLI Nov 22, 2026
@eitsupi
eitsupi force-pushed the feat/interactive-arf-ipc-discovery branch from eed1915 to 0d9523e Compare November 22, 2026 02:57
@eitsupi
eitsupi requested a review from renkun-ken November 22, 2026 03:00

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same-PID restart check and bootstrap over the verified attach connection both passed on 0d9523e. The user guide now covers private session directories, and discovery returned at five seconds with a SIGTERM-handling wrapper. All 60 focused local tests passed on macOS with arf 0.7.2, including the two real adoption tests.

I also ran Connect in a two-folder VS Code 1.145.2 workspace. With a file open in A or B, it ran that folder’s configured executable. The manifest assertion covers the scope change. I’m requesting fixes for the first-folder setting when Connect is launched from an empty or untitled editor and for the pipes left open after a wrapper times out. I’ve included the observed results inline, along with a small developer README correction.

Comment thread src/interactive/manager.ts Resolved
Comment thread src/interactive/arf.ts Resolved
Comment thread src/interactive/README.md Resolved
@eitsupi
eitsupi force-pushed the feat/interactive-arf-ipc-discovery branch from 0d9523e to 04ced2c Compare November 22, 2026 08:40
@eitsupi
eitsupi requested a review from renkun-ken November 22, 2026 08:42
@eitsupi
eitsupi marked this pull request as draft November 22, 2026 08:59
@eitsupi
eitsupi marked this pull request as ready for review November 22, 2026 09:30
@eitsupi eitsupi changed the title refactor(interactive): list arf sessions with the arf CLI feat(interactive): let each workspace folder set its own arf Nov 22, 2026
r.interactive.arfPath had no scope, so VS Code read it per window and
every workspace folder used one value, both for listing running arf
sessions and for new sessions. It is now machine-overridable, so a
folder can set its own arf, which listing and new sessions resolve from
the folder they are for. Without an editor in a workspace folder, as
when Connect runs from an empty or untitled editor, the first folder's
setting applies, as its directory does.
@eitsupi
eitsupi force-pushed the feat/interactive-arf-ipc-discovery branch from e544344 to 026b0e3 Compare November 22, 2026 09:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants