Repository navigation
ENH: expose the integer-grid refinement matrix - #899
Open
bingdongni wants to merge 1 commit into
Open
bingdongni wants to merge 1 commit into
bingdongni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #879. The low-pass filter already contains the integer-grid refinement operator, but callers currently have to assemble it and choose the orientation of the dual filter themselves.
pywt.refinement_matrix(wavelet, dual=False)returns that operator for either scaling function. It keeps the filter grid, including leading or trailing zeros.The tests compare matrix multiplication with subdivision by convolution and decimation. A cubic B-spline also checks the fixed point for its integer samples and the half-eigenvalue for its derivative. The function leaves eigenvector selection and normalization to the caller.
The Linux wheel test ran the installed suite (1,064 passed, two skipped), checked the docstring example, and compared both filters for all 106 built-in discrete wavelets.