Repository navigation
Migration Engine: Copy redirects, subscriptions, retry history and settings to SQL - #6137
Merged
Merged
Conversation
rbev
approved these changes
Nov 19, 2026
warwickschroeder
force-pushed
the
warwick/migration-engine-1
branch
from
November 20, 2026 04:08
f770bf8 to
f76aa71
Compare
warwickschroeder
force-pushed
the
warwick/migration-engine-1
branch
from
November 20, 2026 04:39
f76aa71 to
49f63e6
Compare
- Copy message redirects, subscriptions, retry operations, notification settings and the trial end date - Report rows merged by the SQL key instead of dropping them silently - Delete store-keyed rows when a category is reset for a retry
warwickschroeder
force-pushed
the
migration-engine-7
branch
from
November 20, 2026 05:02
76688fc to
5f62c89
Compare
warwickschroeder
merged commit Nov 20, 2026
750d3ed
into
warwick/migration-engine-1
72 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offline migration now copies five more required categories from RavenDB to SQL. A category that cannot be stored row for row is skipped or merged with a reason, and the SQL target can reset a category so it copies again cleanly.
What this adds
--start-data-migration.--migration-retrycommand comes later.--start-data-migrationlogs only through the instance's own log providers, so lines are no longer printed twice.Tests
ServiceControl.Migration.AcceptanceTests: each new category copied end to end on SQL Server and PostgreSQL, including merges, skips, a retry history larger than one statement, the reset for a retry, endpoint settings surviving the heartbeat sync, and the offline command's log providers.ServiceControl.Persistence.Tests/EFCore/Migration: the new writers and row mappers, their skip reasons and merge details, and that only store-keyed writers delete rows for a retry.ServiceControl.Persistence.Tests.RavenDB/DataMigration: the redirects and subscriptions readers, and every reader finding its document in the right database.ServiceControl.Persistence.Tests.SqlServer: endpoint settings names that differ only in case keep the known endpoint's spelling.ServiceControl.UnitTests/Migration: which skip reasons are harmless and which are faults.