Repository navigation
Upgrade mssql-jdbc to 13.6.2 and add a smoke-test configuration for it #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tonygermano
wants to merge
2
commits into
OpenIntegrationEngine:main
Choose a base branch
from
tonygermano:build/mssql-jdbc-13.6.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−8
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
64 changes: 64 additions & 0 deletions
64
ci/configurations/alpine-temurin21-sqlserver-mssql-jdbc.compose.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| services: | ||
| db: | ||
| platform: linux/amd64 | ||
| image: mcr.microsoft.com/mssql/server:2025-latest | ||
| environment: | ||
| ACCEPT_EULA: Y | ||
| MSSQL_PID: Developer | ||
| MSSQL_SA_PASSWORD: OieSqlServerPassw0rd! | ||
| healthcheck: | ||
| test: | ||
| - CMD-SHELL | ||
| - /opt/mssql-tools18/bin/sqlcmd -C -S 127.0.0.1 -U sa -P "$$MSSQL_SA_PASSWORD" -Q "SELECT 1" || /opt/mssql-tools/bin/sqlcmd -S 127.0.0.1 -U sa -P "$$MSSQL_SA_PASSWORD" -Q "SELECT 1" | ||
| interval: 3s | ||
| timeout: 5s | ||
| retries: 30 | ||
| start_period: 30s | ||
|
|
||
| db-init: | ||
| platform: linux/amd64 | ||
| image: mcr.microsoft.com/mssql/server:2025-latest | ||
| depends_on: | ||
| db: | ||
| condition: service_healthy | ||
| environment: | ||
| MSSQL_SA_PASSWORD: OieSqlServerPassw0rd! | ||
| restart: "no" | ||
| entrypoint: | ||
| - /bin/bash | ||
| - -lc | ||
| - /opt/mssql-tools18/bin/sqlcmd -C -S db -U sa -P "$$MSSQL_SA_PASSWORD" -Q "IF DB_ID('mirthdb') IS NULL CREATE DATABASE mirthdb;" || /opt/mssql-tools/bin/sqlcmd -S db -U sa -P "$$MSSQL_SA_PASSWORD" -Q "IF DB_ID('mirthdb') IS NULL CREATE DATABASE mirthdb;" | ||
|
|
||
| oie: | ||
| image: ${OIE_IMAGE} | ||
| depends_on: | ||
| db-init: | ||
| condition: service_completed_successfully | ||
| environment: | ||
| DATABASE: sqlserver | ||
| DATABASE_URL: jdbc:sqlserver://db:1433;databaseName=mirthdb;encrypt=true;trustServerCertificate=true | ||
| _MP_DATABASE_DRIVER: com.microsoft.sqlserver.jdbc.SQLServerDriver | ||
| DATABASE_USERNAME: sa | ||
| DATABASE_PASSWORD: OieSqlServerPassw0rd! | ||
| DATABASE_MAX_CONNECTIONS: 20 | ||
| DATABASE_MAX_RETRY: 20 | ||
| DATABASE_RETRY_WAIT: 5000 | ||
| ports: | ||
| - "8443:8443" | ||
| healthcheck: | ||
| test: | ||
| - CMD-SHELL | ||
| - bash -lc 'exec 3<>/dev/tcp/127.0.0.1/8443' | ||
| interval: 3s | ||
| timeout: 5s | ||
| retries: 30 | ||
| start_period: 40s | ||
|
|
||
| # Lets the Database Connector metadata test reach this configuration's database. The URL is | ||
| # resolved by the oie service, not the harness, so it is the same one the engine uses. | ||
| harness: | ||
| environment: | ||
| OIE_DB_DRIVER: com.microsoft.sqlserver.jdbc.SQLServerDriver | ||
| OIE_DB_URL: jdbc:sqlserver://db:1433;databaseName=mirthdb;encrypt=true;trustServerCertificate=true | ||
| OIE_DB_USERNAME: sa | ||
| OIE_DB_PASSWORD: OieSqlServerPassw0rd! | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the existing smoke test and drop support for the old one instead? I don't think we need multiple for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I put in the PR description about that change
jTDS is still the default driver, so I didn't want to remove it from the smoke tests yet, but I figured it would get phased out eventually. Would you prefer I drop it from the smoke test now? I at least made it so each driver was running against a different version of SQL Server.