Skip to content

Warn when a server plugin class implements no plugin type - #576

Open
Hisham-InfoGleam wants to merge 1 commit into
OpenIntegrationEngine:mainfrom
Hisham-InfoGleam:fix/398-warn-untyped-server-plugin
Open

Hisham-InfoGleam wants to merge 1 commit into
OpenIntegrationEngine:mainfrom
Hisham-InfoGleam:fix/398-warn-untyped-server-plugin

Conversation

@Hisham-InfoGleam

Copy link
Copy Markdown

Fixes #398.

A server class that implements ServerPlugin but none of the plugin type interfaces is instantiated by initPlugins() and then ignored. It is never started or stopped, and nothing in the log says why.

This change logs a warning that names the plugin and the class. It follows the direction in the issue: the behaviour stays the same, and only the silent part is fixed. The compile-time check is left out.

Tests

  • A class with no plugin type logs the warning and stays unregistered.
  • A ResourcePlugin logs no warning and is registered.
  • ./gradlew :server:test passes locally (851 tests).

@Hisham-InfoGleam
Hisham-InfoGleam marked this pull request as ready for review November 13, 2026 04:53
@github-actions

Copy link
Copy Markdown

Test Results

  142 files  ±0    142 suites  ±0   3m 38s ⏱️ + 1m 5s
  939 tests +2    939 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 101 runs  +2  1 095 ✅ +2  6 💤 ±0  0 ❌ ±0 

Results for commit e3b1ef4. ± Comparison against base commit 22b64a8.

gibson9583
gibson9583 previously approved these changes Nov 16, 2026
mgaffigan
mgaffigan previously approved these changes Nov 20, 2026
initPlugins registers a server class once for each plugin type
interface it implements. A class that implements ServerPlugin but none
of those interfaces was instantiated and then ignored: it was never
added to serverPlugins, so start() and stop() were never called, and
nothing in the log said why.

Log a warning that names the plugin and the class. Which plugins are
registered, started and stopped does not change.

Fixes OpenIntegrationEngine#398

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: Hisham Alrashdan <hisham@infogleam.com>
@Hisham-InfoGleam
Hisham-InfoGleam force-pushed the fix/398-warn-untyped-server-plugin branch from e3b1ef4 to 68c8972 Compare November 21, 2026 19:37
@Hisham-InfoGleam

Copy link
Copy Markdown
Author

Rebased onto the current main to resolve the conflict with the temporary-folder changes in DefaultExtensionControllerTest. The fix itself is unchanged. The two new tests now sit on top of the updated test class. ./gradlew :server:test passes locally (877 tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ServerPlugin implementing no plugin type interface is silently never started or stopped

3 participants