Repository navigation
Fix PR publication locking Refresh after the head advances - #56
Open
rcosteira79 wants to merge 4 commits into
Open
rcosteira79 wants to merge 4 commits into
rcosteira79 wants to merge 4 commits into
Conversation
rcosteira79
commented
Nov 20, 2026
rcosteira79
left a comment
Collaborator
Author
There was a problem hiding this comment.
Submitted from DiffCompass.
| The saved review remains available; reopening a completed review recreates its | ||
| checkout at the recorded PR revision when needed. | ||
|
|
||
| If the PR branch changes before publication, refresh the review and confirm the |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| If the PR branch changes before publication, refresh the review and confirm the | |
| <!-- DiffCompass #55 live regression test only; do not apply. --> | |
| If the PR branch changes before publication, refresh the review and confirm the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PR branch advances after capture, a failed publication can leave a saved pending intent that blocks Refresh and survives restarting DiffCompass. This change lets the reviewer refresh and continue with their comments intact.
Regression coverage includes approvals, requested changes, neutral suggestion submissions, reloads, preserved comments, paginated receipt recovery, unavailable GitHub reads, and storage failures.
Validation:
bun run verifywith CI’s Bun 1.3.14 passed: 1,241 tests passed, 13 skipped, no failures, plus TypeScript and browser-script syntax checks.Live validation against PR #56 used the production browser UI/server and real GitHub responses. Two empty commits advanced the head without changing source. Approval and change-request attempts rejected the stale head, Refresh preserved comments, and an older saved pending session recovered through Refresh. One labelled test-only COMMENT review was published: #56 (review). After intentionally discarding its response, advancing the head again, and reopening the saved session, Retry recovered the same receipt with exactly one remote POST. A second replay forbade all GitHub writes and also passed.
The live run also exposed a missing agent-selection guard in the UI. That guard is fixed; browser recovery now shows its success message with no page errors when no agent is configured. All 86 existing UI tests pass. Temporary test worktrees were removed; the test suggestion was not applied.
Fixes #55.