Repository navigation
Fix wfdb_to_mat conversion and prevent sample wrap - #650
Merged
Merged
Conversation
Co-authored-by: OpenBot <335604065+openbotgit[bot]@users.noreply.github.com>
tompollard
added a commit
that referenced
this pull request
Nov 21, 2026
## Summary Prepare wfdb 4.4.0 for release. - Set the package version to 4.4.0. - Generate the 4.4.0 release notes from all pending changelog fragments. - Fill the previously empty ADC float32 overflow fragment before consuming it. This PR targets `main` now that #650 has merged. Thank you to @goktugozkanmd for the `wfdb_to_mat` fixes and tests in #633. They were incorporated into #650 with the original commit authorship preserved, and are documented in these release notes. ## Checks - Offline test suite on #650: 382 passed, 17 deselected. - Ruff check and format check passed. - Sphinx HTML build with warnings as errors passed. - `uv build` produced the 4.4.0 sdist and wheel. No release tag or package publication is included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch brings the contributor's #633 commit onto current
main, preserving its authorship, and resolves the conflict with newer converter tests. It adds the range safety fix from #641.adc_zeroshift. Promote to a wider MAT type when needed, including when a shifted valid sample would collide with the missing-value marker.ValueErrorbefore writing an output file if the shifted samples cannot fit in the 32-bit WFDB format.adc_res, missing samples, and the 32-bit limit.Verification
The first commit is from #633 by @goktugozkanmd and OpenBot; the second commit addresses #641. This PR supersedes #633 for the release branch.
Closes #641.