Skip to content

Tidy up wfdb_to_mat and its tests after #633 #642

Open

Description

@tompollard

Small cleanups in wfdb_to_mat and its tests, once #633 is merged. They came up while reviewing it.

  • record.n_sig = num_channels does nothing now that num_channels = record.n_sig. desired_length could also just be record.sig_len.
  • The header checksum is computed with the same logic as calc_checksum, so the two could share a helper and not drift apart.
  • test_missing_samples_and_skew_preserved tests two unrelated things, so if the first part fails the skew check doesn't run. It could be split into two tests.
  • test_forward_slash_path only tests something on Windows (it passes with the old code on Linux and macOS). It needs a comment saying so, or someone may remove it later.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions