Skip to content

Use consistent device name and more noteworthy pod details for fake pods - #35

Merged
ps2 merged 2 commits into
LoopKit:mainfrom
itsmojo:fake-pod-detail-consistency-improvements
Nov 20, 2026
Merged

ps2 merged 2 commits into
LoopKit:mainfrom
itsmojo:fake-pod-detail-consistency-improvements

Conversation

@itsmojo

@itsmojo itsmojo commented Nov 20, 2026

Copy link
Copy Markdown

Here are examples of the Pod Details and Previous Pod views for current pod sim for both DASH and Omnipod 5. Note that the Device Name inconsistencies between DASH ( :: Fake POD ::) and Omnipod 5 (pod simulator) and that the Lot Number, Sequence Number, and Firmware Version values aren't particularly noteworthy.

Orig-Pod-Details-Dash Orig-Pod-Details-O5 Orig-Previous-Pod-Dash Orig-Previous-Pod-O5

This PR will make the pod sim use the long time DASH pod sim style Device Name (albeit with more consistent capitalization and spacing) for both pod types (:: Fake Pod ::), per pod type Lot Numbers that stand out better (PD1U11111111 and PH1U11111111 for DASH and O5 pods respectively), distinctive per pod type Sequence Numbers based on the pod type id (4444444 and 5555555 or DASH and O5 pods respectively) and Firmware Version and BLE Firmware Version values of 0.0.0 (indicates that there is no real physical pod device). Using more noteworthy values for these pod sim attributes makes it more obvious in a quick glance of either the Pod Details or Previous Pod views if a pod simulator was used or not.

Pod Details and Previous Pod details views for the updated pod sim for both DASH and Omnipod 5:

New-Pod-Details-Dash New-Pod-Details-O5 New-Previous-Pod-Dash New-Previous-Pod-O5

@ps2

ps2 commented Nov 20, 2026

Copy link
Copy Markdown

I think if the goal is to make the simulator visible, we'd just say something like "pod simulator" based on something Loop can detect accurately, rather than trying to make the other fields look bad/unrealistic. But I don't see this causing issues, so I'll approve.

@ps2
ps2 merged commit 7cc05f5 into LoopKit:main Nov 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants