Repository navigation
Use consistent device name and more noteworthy pod details for fake pods - #35
Merged
ps2 merged 2 commits intoNov 20, 2026
Merged
Conversation
|
I think if the goal is to make the simulator visible, we'd just say something like "pod simulator" based on something Loop can detect accurately, rather than trying to make the other fields look bad/unrealistic. But I don't see this causing issues, so I'll approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are examples of the Pod Details and Previous Pod views for current pod sim for both DASH and Omnipod 5. Note that the Device Name inconsistencies between DASH (
:: Fake POD ::) and Omnipod 5 (pod simulator) and that the Lot Number, Sequence Number, and Firmware Version values aren't particularly noteworthy.This PR will make the pod sim use the long time DASH pod sim style Device Name (albeit with more consistent capitalization and spacing) for both pod types (
:: Fake Pod ::), per pod type Lot Numbers that stand out better (PD1U11111111andPH1U11111111for DASH and O5 pods respectively), distinctive per pod type Sequence Numbers based on the pod type id (4444444and5555555or DASH and O5 pods respectively) and Firmware Version and BLE Firmware Version values of0.0.0(indicates that there is no real physical pod device). Using more noteworthy values for these pod sim attributes makes it more obvious in a quick glance of either the Pod Details or Previous Pod views if a pod simulator was used or not.Pod Details and Previous Pod details views for the updated pod sim for both DASH and Omnipod 5: