Repository navigation
tests: ptp-iterative prints where its UI crashes - #4873
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
The UI of tests/ptp-iterative segfaulted once on CI (rip-headless, exit 139) and left nothing to show where: the lines it had printed were still in the stdout buffer the crash threw away, and Python gives no stack on a fatal signal by default. Enable faulthandler, so a fatal signal prints the Python stack to stderr, which runtests shows on a failure, and line-buffer stdout so the progress lines printed before the crash reach the log. Checked by forcing a segfault before the second preview: the stack names the line, and the output up to it is in the result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI of tests/ptp-iterative segfaulted once on CI (rip-headless on #4870, exit 139; a rerun passed) and left nothing to show where: the lines it had printed were still in the stdout buffer the crash threw away, and Python prints no stack on a fatal signal by default. I could not reproduce it locally.
This enables faulthandler, so a fatal signal prints the Python stack to stderr, which runtests shows on a failure, and line-buffers stdout so the lines printed before the crash reach the log.
I checked it by forcing a segfault before the second preview: the stack names the line, and the output up to it is in the result.