Repository navigation
axis: the first jog after the MDI tab no longer stops at once - #4872
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
Raising the Manual tab focuses ".", and the first jog then focuses its axis button. Tk reports that as a FocusOut on "." with detail NotifyInferior, which the binding took for the window losing the focus, so jog_off_all() stopped the jog a fraction of a millimeter in. Ignore NotifyInferior; losing the focus to another application still stops the jogs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After using the MDI tab, the first click on a jog button in AXIS moves a fraction of a millimeter and stops; the second click jogs normally.
Raising the Manual tab focuses
., and the first jog then focuses its axis button. Tk reports that as a FocusOut on.with detail NotifyInferior, which the binding took for the window losing the focus, sojog_off_all()stopped the jog. The fix ignores NotifyInferior; losing the focus to another application still stops the jogs.Checked with AXIS under Xvfb on sim/axis/axis_mm.ini: before, the first jog after the MDI tab stopped at 0.25 mm; after, it runs like the second.