Repository navigation
axis: remember the file opened at startup so reload works - #4869
Merged
Merged
Conversation
Since 48f38c7 only open_file_name sets loaded_file, and the file given on the command line, in AXIS_OPEN_FILE or in [DISPLAY]OPEN_FILE is opened by open_initial_file through open_file_guts directly. With loaded_file unset, Reload, Edit, Properties and Save G-code As did nothing for that file, and neither did the reloads after Touch Off, clearing offsets or a tool length change, so the preview kept the old offsets and rotation and changes on disk were not read. Fixes LinuxCNC#4866
grandixximo
approved these changes
Nov 20, 2026
Contributor
|
@Sigma1912 Can you confirm fix works on your end as well? |
Contributor
|
Yes, this works for me. Thanks for the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 48f38c7 only open_file_name sets loaded_file, and the file given on the command line, in AXIS_OPEN_FILE or in [DISPLAY]OPEN_FILE is opened by open_initial_file through open_file_guts directly. With loaded_file unset, Reload, Edit, Properties and Save G-code As did nothing for that file, and neither did the reloads after Touch Off, clearing offsets or a tool length change, so the preview kept the old offsets and rotation and changes on disk were not read.
Fixes #4866