Skip to content

refactor: import features from their defining modules - #1040

Draft
PaulHax wants to merge 1 commit into
Kitware:mainfrom
PaulHax:feature-surface-modules
Draft

PaulHax wants to merge 1 commit into
Kitware:mainfrom
PaulHax:feature-surface-modules

Conversation

@PaulHax

@PaulHax PaulHax commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

The processing and reference lines features exposed their public names through index.ts files that only re-exported other modules, and src/io/index.ts mixed the reader registry with a re-export of io.ts. This conflicts with the project rule against index and barrel modules, and it makes a reader follow one extra hop to find where a name is defined.

Callers now import from the defining files. src/processing/index.ts becomes src/processing/integration.ts, which still registers the processing config section and the launch-load subscriber when App.vue imports it at boot. src/io/index.ts becomes src/io/readerRegistry.ts, and the helpers it re-exported are imported from src/io/io.ts. src/referenceLines/index.ts is removed.

The feature boundary in eslint.config.js no longer allows only the index. Each feature with a public surface lists its public modules: processing exposes integration, store and types, and reference lines exposes ReferenceLines.vue, ReferenceLineSegments.vue, geometry and store. Imports of any other module of a feature from outside it still fail lint. The pure-layer rules are unchanged apart from dropping the entry for the bare directory import, which no longer resolves.

The processing and reference lines features exposed their public names
through index modules that re-exported other files, and the io directory
had an index that mixed the reader registry with a re-export of io.ts.
Callers now import from the files that define each name, which matches the
project rule against index and barrel modules.

The feature boundary in eslint.config.js lists each feature's public
modules instead of allowing only the index. The processing module that
registers its config section at boot is now integration.ts, and the reader
registry is io/readerRegistry.ts.
@netlify

netlify Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 677fee9
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/6b00b311c36cc507a30680f9
😎 Deploy Preview https://deploy-preview-1040--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant