Skip to content

fix: preserve Roslyn host compatibility - #539

Merged
BenjaminMichaelis merged 2 commits into
mainfrom
fix/align-roslyn-versions
Nov 21, 2026
Merged

BenjaminMichaelis merged 2 commits into
mainfrom
fix/align-roslyn-versions

Conversation

@BenjaminMichaelis

@BenjaminMichaelis BenjaminMichaelis commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Keep both production Roslyn references pinned to 4.8.0 for older compiler and IDE hosts.
  • Pin each compatibility job to its matrix SDK instead of selecting the newest preinstalled SDK.
  • Install the built analyzer from the actual local source path using an isolated package cache, and fail immediately if installation fails.

Validation

  • Analyzer and code-fix projects build and pack successfully.
  • Corrected compatibility script passes locally on SDK 9.0.320 and 10.0.403 with zero warnings or errors.
  • SDK 8 is not installed locally; the CI matrix covers SDK 8, 9, and 10.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 20, 2026 06:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Roslyn 5.6.0 dependencies prevent the analyzer from loading on supported .NET 8/9 compiler hosts and code fixes from loading in older IDE hosts, disabling diagnostics and fixes.

1 open issue
What changed in this PR

This PR aligns the analyzer and code-fix projects with the centrally managed Roslyn 5.6.0 packages already used by tests.

Changes:

  • Removes the analyzer’s Roslyn 4.8.0 version override.
  • Removes the code-fix project’s Workspaces 4.8.0 version override.
File Description
IntelliTect.Analyzer/​IntelliTect.Analyzer/​IntelliTect.Analyzer.csproj Uses the central Microsoft.CodeAnalysis.CSharp version.
IntelliTect.Analyzer/​IntelliTect.Analyzer.CodeFixes/​IntelliTect.Analyzer.CodeFixes.csproj Uses the central Microsoft.CodeAnalysis.CSharp.Workspaces version.

Review effort: Balanced

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" VersionOverride="4.8.0" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" />
Restore production Roslyn 4.8.0 overrides. Pin compatibility jobs to their matrix SDK, install the built package from its actual path in an isolated cache, and stop on installation failures.
@BenjaminMichaelis BenjaminMichaelis changed the title fix: align production Roslyn package versions fix: preserve Roslyn host compatibility Nov 21, 2026
@BenjaminMichaelis
BenjaminMichaelis merged commit 8a6a0ab into main Nov 21, 2026
5 checks passed
@BenjaminMichaelis
BenjaminMichaelis deleted the fix/align-roslyn-versions branch November 21, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants