Repository navigation
Support guestbook responses when launching file external tools - #509
Open
ChengShi-1 wants to merge 1 commit into
Open
ChengShi-1 wants to merge 1 commit into
ChengShi-1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an optional
guestbookResponsetogetFileExternalToolResolved. The SDK reuses the download API’s Guestbook response type and sends the completed form in the file tool’s/toolUrlrequest. Dataverse can then include the resulting Guestbook record ID in the tool callback. This supports both embedded preview and opening the same tool in a new window.Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
GetFileExternalToolDTO. TheguestbookResponsefield is optional for existing callers.Suggestions on how to test this:
npm run test:unit -- --runInBand test/unit/externalToolsto verify the SDK request body.Is there a release notes or changelog update needed for this change?:
Yes. Added an entry under Unreleased in
CHANGELOG.md.Additional documentation:
Updated the Get File External Tool Resolved example in
docs/useCases.md.