Repository navigation
Add viewed file toggles with optional automatic collapse - #21
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Reviewed cc577c3: no production defects found in the code audit or native iPhone UI run. One reproducible UIKit test-harness issue is commented inline.
Validation: 179 macOS tests passed; new iOS-only tests: 3 passed, 1 failed (same failure reproduced independently). All 7 CI checks passed, but the macOS test job excludes these UIKit tests. Native Example build and viewed/collapse/settings/reuse/Reduce Motion checks passed on iPhone 17 / iOS 27. iOS 16 runtime and full VoiceOver spoken navigation remain untested.
| XCTAssertTrue(viewed.accessibilityActivate()) | ||
| XCTAssertEqual(viewedTaps, 1) | ||
| XCTAssertEqual(collapseTaps, 0) | ||
| collapse.sendActions(for: .touchUpInside) |
There was a problem hiding this comment.
[P2] Make the control-dispatch test runnable in the package test target
This new test fails when actually run on an iOS simulator via the generated MarkdownView-Package scheme: xcodebuild test -scheme MarkdownView-Package -destination 'platform=iOS Simulator,name=iPhone 17' -only-testing:MarkdownViewTests/DiffFilesViewedTests CODE_SIGNING_ALLOWED=NO. The package test bundle has no host app, so this sendActions emits UIApp is nil which means we cannot dispatch control actions to their targets; collapseTaps remains 0 and line 93 fails. Reproduced both with all four new tests and with this test alone; the other three pass.
Please use an app-hosted UIKit test target for this dispatch check, or make the test work without a UIApplication host while preserving the independent-action assertions. The current macOS-only CI does not catch this because the entire file is behind #if canImport(UIKit). The same collapse action works in the native Example app, so this is a test-harness defect rather than a confirmed production interaction bug.
v0 Session