Skip to content

Add viewed file toggles with optional automatic collapse - #21

Merged
vercel[bot] merged 2 commits into
mainfrom
v0/file-viewed-toggle
Nov 11, 2026
Merged

vercel[bot] merged 2 commits into
mainfrom
v0/file-viewed-toggle

Conversation

@vercel

@vercel vercel Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
  • Added "viewed" toggles to files to help users track progress within the file explorer.
  • Implemented an optional setting to automatically collapse files once they have been marked as viewed.

v0 Session

@vercel vercel Bot added the v0 label Nov 9, 2026
@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor Author

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
markdown-view Ready Ready Preview, v0 Nov 9, 2026 8:27pm UTC
markdownview Ready Ready Preview, v0 Nov 9, 2026 8:27pm UTC

Request Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed cc577c3: no production defects found in the code audit or native iPhone UI run. One reproducible UIKit test-harness issue is commented inline.

Validation: 179 macOS tests passed; new iOS-only tests: 3 passed, 1 failed (same failure reproduced independently). All 7 CI checks passed, but the macOS test job excludes these UIKit tests. Native Example build and viewed/collapse/settings/reuse/Reduce Motion checks passed on iPhone 17 / iOS 27. iOS 16 runtime and full VoiceOver spoken navigation remain untested.

Native viewed-file UI recording preview

Viewed file auto-collapsed independently of the other file

Full UI recording and Devin session

XCTAssertTrue(viewed.accessibilityActivate())
XCTAssertEqual(viewedTaps, 1)
XCTAssertEqual(collapseTaps, 0)
collapse.sendActions(for: .touchUpInside)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Make the control-dispatch test runnable in the package test target

This new test fails when actually run on an iOS simulator via the generated MarkdownView-Package scheme: xcodebuild test -scheme MarkdownView-Package -destination 'platform=iOS Simulator,name=iPhone 17' -only-testing:MarkdownViewTests/DiffFilesViewedTests CODE_SIGNING_ALLOWED=NO. The package test bundle has no host app, so this sendActions emits UIApp is nil which means we cannot dispatch control actions to their targets; collapseTaps remains 0 and line 93 fails. Reproduced both with all four new tests and with this test alone; the other three pass.

Please use an app-hosted UIKit test target for this dispatch check, or make the test work without a UIApplication host while preserving the independent-action assertions. The current macOS-only CI does not catch this because the entire file is behind #if canImport(UIKit). The same collapse action works in the native Example app, so this is a test-harness defect rather than a confirmed production interaction bug.

@vercel
vercel Bot merged commit 4f88e9b into main Nov 11, 2026
7 checks passed
@vercel
vercel Bot deleted the v0/file-viewed-toggle branch November 11, 2026 00:33

This branch was successfully deployed

1 active deployment
Preview – markdown-view — 672c1ca9 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant