Skip to content

fix(storagecontrol): guard CLI args in get_rapid_cache sample - #14989

Closed
pwnhaven-afk wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
pwnhaven-afk:storagecontrol-arg-guard
Closed

pwnhaven-afk wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
pwnhaven-afk:storagecontrol-arg-guard

Conversation

@pwnhaven-afk

Copy link
Copy Markdown

Adds a usage guard so the sample prints usage instead of raising IndexError when invoked without arguments.

@pwnhaven-afk
pwnhaven-afk requested review from a team as code owners November 20, 2026 16:09
@google-cla

google-cla Bot commented Nov 20, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Nov 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a command-line argument check to the get_rapid_cache.py script to ensure the correct number of arguments are provided before execution. There are no review comments, and I have no feedback to provide.

@pwnhaven-afk

Copy link
Copy Markdown
Author

Closing without merging — this branch was an infrastructure probe of the repo's Cloud Build trigger behaviour (checking whether the trigger's file filter and comment-control gate are reachable from a fork PR), not a change I'm proposing. No files intended to land; apologies for the noise.

@pwnhaven-afk
pwnhaven-afk deleted the storagecontrol-arg-guard branch November 20, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant