Repository navigation
feat(arc): give the listener container resources - #263
Merged
Merged
Conversation
The chart gives each scale set's listener no resources, and the overlay's
listener container replaces any a profile's values file sets, since the
role's merge and Helm both replace lists.
A listener with no memory request is always over it,
so under node memory pressure the kubelet evicts it before idle runner
pods within their requests, whatever its PriorityClass,
and the scale set takes no job until it is rescheduled.
github_runner_arc_listener_resources (default {}) is rendered into the
overlay's listener container.
When set it also builds the listener container on its own,
without a node label, probes or a priority class;
when empty the overlay renders exactly as before.
Fixes #261
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
github_runner_arc_listener_resources(default{}), rendered asresourceson the overlay'slistenercontainer. The overlay's containers list replaces a values file's, so before this a listenerresourcesblock set in a profile's values file was dropped and the listener always ran BestEffort, which the kubelet evicts under memory pressure ahead of idle runner pods within their requests regardless of priority (Node-pressure eviction, "Pod selection for kubelet eviction").Non-empty resources also open the
listenerTemplateblock on their own, so they reach the listener with no node label, probes or priority class set. Empty resources render the overlay byte for byte as before (checked against themaintemplate for the default, node label, probes and priority class cases).Documented in the role README, defaults and argument specs, with a mapping check in
validate.yml.Tests in
tests/unit/test_scale_set_overlay.pycover each case that builds the listener container plus none of them, and a render throughtasks/render_scale_set_values.ymlover a values file with its own listener resources. They fail onmainand fail again when the template's condition, theresourcesguard or the rendered value is broken.Fixes #261