Repository navigation
test(behat): seed the latest PHP row instead of creating it - #5
Merged
Merged
Conversation
site-type-wp and site-type-php now store `--php=latest` as the concrete default version, so a site created with `--php=latest` no longer has a `latest` row. The fixture is created on the default version and its row set to `latest` with the existing database step (undone after the scenario), so the runtime-resolve branch stays covered with or without that change.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Behat scenario "A site on PHP "latest" is posted with the version it really runs" created its fixture with
--type=php --php=latestand expected alatestrow in the EasyEngine database. With EasyEngine/site-type-wp#255 and EasyEngine/site-type-php#127,--php=latestis stored as the concrete default version (8.5), so that fixture would no longer have alatestrow and the scenario would fail on the next dev-develop run.The fixture is now created on the default version and its
php_versionrow is set tolatestwith the existingI set the column … in the EasyEngine databasestep (restored after the scenario). Rows stored aslatestby older releases still exist until the site-command migration pins them, soee dash init's runtime-resolve branch (ee shell … php -v) stays covered, and the scenario passes with or without the site-type change.Test-only; no code change.