Repository navigation
Fix the FAQ and comparison sign-up buttons that led to a 404 - #520
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/faqand the "Get Started Free" button on every/compare/:competitorpage linked to/register, which has returned 404 since registration moved to/login?action=register(d635352). They now go to/login?action=register, like the header and home hero. The FAQ answer that sent people to "lessons.church/register" now says "lessons.church".Evidence
/register→ 404 from/faq. Productionhttps://lessons.church/registeralso returns 404.CompareClient.tsx) and on the FAQ.Proof
tests/seo.spec.tscase, " links only to pages that exist" (for/faqand/compare/answers-in-genesis), requests every internal href in the server HTML without following redirects./registerreceived 404).npx playwright test seo.spec.tsgave 23 passed (slot 5 demo stack).npx tsc --noEmit: no errors. eslint on the changed files: clean.