Skip to content

Fix the FAQ and comparison sign-up buttons that led to a 404 - #520

Merged
Charlie-Carson merged 1 commit into
mainfrom
maint-seo-2026-11-21
Nov 22, 2026
Merged

Charlie-Carson merged 1 commit into
mainfrom
maint-seo-2026-11-21

Conversation

@Charlie-Carson

Copy link
Copy Markdown
Contributor

Summary

  • The "Start Free Today" button on /faq and the "Get Started Free" button on every /compare/:competitor page linked to /register, which has returned 404 since registration moved to /login?action=register (d635352). They now go to /login?action=register, like the header and home hero. The FAQ answer that sent people to "lessons.church/register" now says "lessons.church".

Evidence

  • An internal-link check of the server HTML found /register → 404 from /faq. Production https://lessons.church/register also returns 404.
  • The broken link is in every comparison page (CompareClient.tsx) and on the FAQ.

Proof

  • A new tests/seo.spec.ts case, " links only to pages that exist" (for /faq and /compare/answers-in-genesis), requests every internal href in the server HTML without following redirects.
    • On main: 2 failed (/register received 404).
    • With the change: npx playwright test seo.spec.ts gave 23 passed (slot 5 demo stack).
  • npx tsc --noEmit: no errors. eslint on the changed files: clean.

@vercel

vercel Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
lessons-app Ready Ready Preview Nov 22, 2026 6:33am UTC

Request Review

@Charlie-Carson
Charlie-Carson merged commit b7c3cfe into main Nov 22, 2026
4 checks passed
@Charlie-Carson
Charlie-Carson deleted the maint-seo-2026-11-21 branch November 22, 2026 06:37

This branch was successfully deployed

1 active deployment
Preview — 37b2080c Deployed Nov 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant