Skip to content

Release v1.2.1 - #14

Merged
DeviaVir merged 5 commits into
v1from
release/v1.2.1
Nov 18, 2026
Merged

DeviaVir merged 5 commits into
v1from
release/v1.2.1

Conversation

@DeviaVir

Copy link
Copy Markdown
Member

Promotes main to v1 (replaces #13, which conflicted: earlier releases were squash-merged into v1, so main and v1 have different histories).

This branch is v1 with main merged in; its tree is identical to main (git diff origin/main is empty). Content change against v1:

After merge: tag v1.2.1 on the merge commit. Use a merge commit (not squash) for this PR, so the next release from main does not conflict again.

DeviaVir and others added 5 commits October 30, 2026 13:16
publish.yml: security fixes for explicit tags, artifact hand-off and OCI checks
* publish.yml: optional static-asset upload before the image push

New optional inputs static-assets-path and static-assets-destination.
When set, the publish job reads that directory from the validated local
OCI layout (layers applied in order, OCI whiteouts honored, links and
special files rejected, size and count limits) without executing caller
content, and uploads it to the GCS destination with the publisher's
access token before the image is pushed.

Uploads are create-only (ifGenerationMatch=0). An existing object must
match byte for byte and in serving metadata, otherwise the job fails.
Text assets are stored gzip-encoded; all objects get
"public, max-age=31536000, immutable".

Use case: content-hashed web assets (for example Next.js .next/static
with assetPrefix) stay available for every build, so rolling deploys
cannot serve HTML that references chunks missing from the other pods.
Both inputs empty: no behaviour change.

* publish.yml: harden static-asset upload after security review

- Gate the step on the raw inputs and fail closed when the prepare
  outputs are missing (GitHub drops outputs that contain a secret value,
  which would otherwise skip the upload and push the image anyway).
- Name the colliding object in the error; README: separate bucket or
  prefix per trust level, and how to recover from a collision.
- Own AssetError for the step's messages; every other error is reported
  generically, so build-controlled text never reaches the log.
- Reject PAX sparse maps before tarfile parses them.
- On a gzip md5 mismatch with matching content hash, compare the
  decompressed stored object (bounded) instead of failing, so a runner
  zlib change cannot block unchanged assets.
- Cancel queued uploads after the first failure.
- Publish job timeout 35 minutes; document amd64-only asset upload.

* publish.yml: bound all tar extension headers; single-platform static assets

Second review round:
- Include Solaris extended headers (type X) in the 1 MiB extension-header
  limit and cap the total of global PAX headers per layer at 1 MiB.
- Fail closed at startup if the private tarfile hooks the limits rely
  on no longer exist.
- Reject static assets with more than one platform: separate builds can
  produce different asset names and only one platform would be uploaded.
- README: one-line Cache-Control.

* publish.yml: final review items for static-asset upload

- Publish job timeout 35 minutes only when static assets are used;
  other callers keep 20.
- An existing object with Content-Disposition or Content-Language is a
  collision.
- static-assets-path rejects all control characters.
- README: whole-image parsing limits apply to every layer.

---------

Co-authored-by: chase (AI) <chase+robot@blockstream.com>
Bumps the actions group with 1 update: [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer).


Updates `sigstore/cosign-installer` from 4.1.2 to 4.1.3
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@6f9f177...756fe2d)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-version: 4.1.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GCS rejects a multipart upload with HTTP 400 when the Content-Type of the
media part differs from the metadata contentType: "Content-Type specified in
the upload (application/octet-stream) does not match Content-Type specified in
metadata (text/javascript; charset=utf-8)". Every static-asset upload failed
(first seen in Blockstream/dxp-frontend run 44276953431), so the image was
never pushed. Use the same content type in both parts.

Verified against GCS with the same request shape: HTTP 200, stored with the
expected contentType, contentEncoding gzip and cacheControl.
# Conflicts:
#	.github/workflows/publish.yml
@DeviaVir DeviaVir mentioned this pull request Nov 18, 2026
@DeviaVir
DeviaVir marked this pull request as ready for review November 18, 2026 12:02
@DeviaVir
DeviaVir requested a review from a team as a code owner November 18, 2026 12:02
@DeviaVir
DeviaVir enabled auto-merge (squash) November 18, 2026 12:02
@DeviaVir
DeviaVir disabled auto-merge November 18, 2026 12:02
@DeviaVir
DeviaVir enabled auto-merge November 18, 2026 12:03

@N3X14 N3X14 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeviaVir
DeviaVir merged commit 88b6629 into v1 Nov 18, 2026
1 check passed
@DeviaVir
DeviaVir deleted the release/v1.2.1 branch November 18, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants