Skip to content

Fix resume_after error related to write_data_dictionary (#999) - #1140

Open
josiekre wants to merge 1 commit into
ActivitySim:mainfrom
wsp-sag:fix-resume-after
Open

josiekre wants to merge 1 commit into
ActivitySim:mainfrom
wsp-sag:fix-resume-after

Conversation

@josiekre

Copy link
Copy Markdown
Contributor

Fixes the bug outlined in #999.

I ran the full population with activitysim on v1.6 with sandag on latest on main at 68b23d4 successfully using:

uv run --project ../activitysim activitysim run -c configs/common -c configs/resident -d data -o output -s settings_mp.yaml --ext extensions

Then I applied the bug fix sitting in this pull request (or switched branches in activitysim) and ran again successfully to check that it does not create any errors on a normal run:

uv run --project ../activitysim activitysim run -c configs/common -c configs/resident -d data -o outputwfix -s settings_mp.yaml --ext extensions

Applied resume_after to sandag in settings_mp.yaml and ran successfully again with bug fix applied using:

uv run --project ../activitysim activitysim run -c configs/common -c configs/resident -d data -o outputwfix -s settings_mp.yaml --ext extensions

Then reverted bug fix back and ran again with fail as documented in #999.

uv run --project ../activitysim activitysim run -c configs/common -c configs/resident -d data -o outputwfix -s settings_mp.yaml --ext extensions

I used Copilot to help me write a simple test too. This is sitting in the pull request too. Under standard review practices for this project, what happens next for review?

@janzill

janzill commented Nov 22, 2026

Copy link
Copy Markdown
Contributor

Thanks, Josie! PRs get triaged at the weekly engineering meetings. To be merged, they need to be reviewed and approved by an engineering team member and CI needs to be passing. If there are comments or requests, they will be added to the PR directly.
Currently, CI is failing because the new test file is missing a newline at the end of the file, can you fix this please? You can also install pre-commit hooks on your development machine and things like this will be automatically checked for you.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants