From 34814accba8822681ba62c0821ebe48b98f1435f Mon Sep 17 00:00:00 2001 From: zariiii9003 <52598363+zariiii9003@users.noreply.github.com> Date: Sat, 21 Nov 2026 03:05:06 +0100 Subject: [PATCH 1/2] add skip conditions for multicast tests --- test/back2back_test.py | 23 ++++++++++------------- test/config.py | 37 +++++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 13 deletions(-) diff --git a/test/back2back_test.py b/test/back2back_test.py index ce7c39e2a..b82e89b27 100644 --- a/test/back2back_test.py +++ b/test/back2back_test.py @@ -18,10 +18,11 @@ from .config import ( IS_CI, - IS_OSX, IS_PYPY, TEST_CAN_FD, TEST_INTERFACE_SOCKETCAN, + TEST_UDP_MULTICAST_IPv4, + TEST_UDP_MULTICAST_IPv6, ) @@ -291,16 +292,14 @@ class BasicTestSocketCan(Back2BackTestCase): CHANNEL_2 = "vcan0" -# this doesn't even work on Travis CI for macOS; for example, see -# https://travis-ci.org/github/hardbyte/python-can/jobs/745389871 -@unittest.skipIf( - IS_CI and IS_OSX, - "not supported for macOS CI", -) @unittest.skipUnless( is_msgpack_installed(raise_exception=False), "msgpack not installed", ) +@unittest.skipUnless( + TEST_UDP_MULTICAST_IPv4, + "IPv4 UDP multicast not available on this host", +) class BasicTestUdpMulticastBusIPv4(Back2BackTestCase): INTERFACE_1 = "udp_multicast" CHANNEL_1 = UdpMulticastBus.DEFAULT_GROUP_IPv4 @@ -312,16 +311,14 @@ def test_unique_message_instances(self): super().test_unique_message_instances() -# this doesn't even work for loopback multicast addresses on Travis CI; for example, see -# https://travis-ci.org/github/hardbyte/python-can/builds/745065503 -@unittest.skipIf( - IS_CI and IS_OSX, - "not supported for macOS CI", -) @unittest.skipUnless( is_msgpack_installed(raise_exception=False), "msgpack not installed", ) +@unittest.skipUnless( + TEST_UDP_MULTICAST_IPv6, + "IPv6 UDP multicast not available on this host", +) class BasicTestUdpMulticastBusIPv6(Back2BackTestCase): HOST_LOCAL_MCAST_GROUP_IPv6 = "ff11:7079:7468:6f6e:6465:6d6f:6d63:6173" diff --git a/test/config.py b/test/config.py index d308a8cc8..c449b374e 100644 --- a/test/config.py +++ b/test/config.py @@ -8,6 +8,8 @@ """ import platform +import socket +import struct from os import environ as environment @@ -59,3 +61,38 @@ def env(name: str) -> bool: TEST_CAN_FD = True TEST_INTERFACE_SOCKETCAN = IS_LINUX and env("TEST_SOCKETCAN") + + +def _can_use_multicast(group: str) -> bool: + """Check whether the host can send a datagram to the multicast ``group`` and receive it back. + + This mirrors what :class:`~can.interfaces.udp_multicast.UdpMulticastBus` does: join the group + on an interface chosen by the kernel and rely on multicast loopback. It fails, for example, in + containers without an IPv6 multicast route or on hosts whose firewall drops incoming multicast. + """ + is_ipv6 = ":" in group + family = socket.AF_INET6 if is_ipv6 else socket.AF_INET + probe = b"python-can multicast probe" + try: + with socket.socket(family, socket.SOCK_DGRAM) as sock: + sock.settimeout(0.5) + sock.bind(("", 0)) + port = sock.getsockname()[1] + if is_ipv6: + # interface index 0 lets the kernel choose the interface by route lookup + request = socket.inet_pton(family, group) + struct.pack("@I", 0) + sock.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_JOIN_GROUP, request) + else: + request = socket.inet_aton(group) + struct.pack("@I", socket.INADDR_ANY) + sock.setsockopt(socket.IPPROTO_IP, socket.IP_ADD_MEMBERSHIP, request) + sock.sendto(probe, (group, port)) + return sock.recv(len(probe)) == probe + except OSError: # includes the timeout + return False + + +# UDP multicast doesn't work on macOS CI, not even for loopback addresses. +# The probe groups are arbitrary: the kernel picks the interface by a route lookup for the whole +# multicast range, so every group of the same family and scope gives the same result. +TEST_UDP_MULTICAST_IPv4 = not (IS_CI and IS_OSX) and _can_use_multicast("239.255.0.1") +TEST_UDP_MULTICAST_IPv6 = not (IS_CI and IS_OSX) and _can_use_multicast("ff11::1") From d59a30a57196046061578ba06540b8e01e475e9b Mon Sep 17 00:00:00 2001 From: zariiii9003 <52598363+zariiii9003@users.noreply.github.com> Date: Sat, 21 Nov 2026 03:09:18 +0100 Subject: [PATCH 2/2] do not skip macos? --- test/config.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/config.py b/test/config.py index c449b374e..56df944a1 100644 --- a/test/config.py +++ b/test/config.py @@ -91,8 +91,7 @@ def _can_use_multicast(group: str) -> bool: return False -# UDP multicast doesn't work on macOS CI, not even for loopback addresses. # The probe groups are arbitrary: the kernel picks the interface by a route lookup for the whole # multicast range, so every group of the same family and scope gives the same result. -TEST_UDP_MULTICAST_IPv4 = not (IS_CI and IS_OSX) and _can_use_multicast("239.255.0.1") -TEST_UDP_MULTICAST_IPv6 = not (IS_CI and IS_OSX) and _can_use_multicast("ff11::1") +TEST_UDP_MULTICAST_IPv4 = _can_use_multicast("239.255.0.1") +TEST_UDP_MULTICAST_IPv6 = _can_use_multicast("ff11::1")