diff --git a/plugins/minimax-ai/minimax-bot/.minimax-plugin/plugin.json b/plugins/minimax-ai/minimax-bot/.minimax-plugin/plugin.json index 12fa8746..555b7cd3 100644 --- a/plugins/minimax-ai/minimax-bot/.minimax-plugin/plugin.json +++ b/plugins/minimax-ai/minimax-bot/.minimax-plugin/plugin.json @@ -2,7 +2,7 @@ "schemaVersion": 1, "name": "minimax-bot", "displayName": "MiniMax Bot", - "version": "0.7.33", + "version": "0.7.37", "description": "Turn MiniMax Code into an always-on team of Bots. A Chief Bot helps you build the team; in group chats the admin answers and @mentions hand work to other members. Every Bot has its own octopus avatar and memory, with scheduled tasks and usage stats.", "author": "MiniMax Code", "icon": "icon.png", diff --git a/plugins/minimax-ai/minimax-bot/README.md b/plugins/minimax-ai/minimax-bot/README.md index c2fbd553..f74bf351 100644 --- a/plugins/minimax-ai/minimax-bot/README.md +++ b/plugins/minimax-ai/minimax-bot/README.md @@ -122,6 +122,12 @@ The hand-over between two Bots of a group carried the tail of the previous reply - Stopping before the run exists now marks the task stopped and saves that, and a task already marked stopped no longer starts a background turn. - A task that had already started is unchanged: it is stopped by aborting its run, as before. +## 0.7.37 A round of passes does not hand [PASS] back as its outcome + +- When a member of a group has nothing to add it replies `[PASS]` and is skipped. That turn was still kept as the round's result, so a discussion that ended on a pass reported `[PASS]` as what it produced. A group task opened from a private chat showed exactly that in its result line. +- It was worse when an earlier member had said something real: the last pass replaced the round's text with `[PASS]`, so the work that was actually done was dropped from the result and only the chat still had it. +- A pass is no longer kept as the round's result. The pass itself is still marked and still skipped, so nothing changes about who speaks; a round in which everybody passes now hands back nothing, and a round that ends on a pass keeps the last thing that was really said. + ## 0.7.10 Optional group notes - A group can keep a note of what it said. After every round the group records the closing lines of the replies, and every Bot of the group gets that record in its standing brief. diff --git a/plugins/minimax-ai/minimax-bot/miniapp/node/engine.mjs b/plugins/minimax-ai/minimax-bot/miniapp/node/engine.mjs index 8a1ead05..b9723e81 100644 --- a/plugins/minimax-ai/minimax-bot/miniapp/node/engine.mjs +++ b/plugins/minimax-ai/minimax-bot/miniapp/node/engine.mjs @@ -1333,18 +1333,21 @@ export class Engine { const handover = this.handoverFor(fresh, noteRound); hops += 1; const result = await this.runBotTurn({ bot, chatId, text: '', kind: 'group', sourceMessageId, sourceMessageIds, signal: options.signal, taskId: options.taskId, handover }); - lastResult = result; accepted ||= result.accepted; if (result.status === 'aborted' && (options.signal?.aborted || loop.cancelled)) queue.unshift(botId); - if (result.safeToContinue === false) break; - // Resume this member's verification under the same task before advancing the group. - if (result.status === 'done' && result.waitingForTasks) break; + // The caller needs the stopped turn to resume this member before advancing the group. + if (result.safeToContinue === false || (result.status === 'done' && result.waitingForTasks)) { + lastResult = result; + break; + } + // An ordinary pass contributes nothing to the round's result. if (result.status === 'done' && !result.pendingQuestion && PASS_RE.test(result.text)) { await this.store.updateMessage(chatId, result.messageId, { status: 'pass' }); const updated = (await this.store.getMessages(chatId)).find((m) => m.id === result.messageId); this.broadcast({ type: 'message.upsert', chatId, message: updated }); continue; } + lastResult = result; if (result.status === 'error' && !loop.cancelled) { // One member could not reply (its error and a retry button are in the chat): the round // goes on. If nobody else is queued, the admin picks it up so the user is not left hanging. diff --git a/plugins/minimax-ai/minimax-bot/miniapp/node/mcp.mjs b/plugins/minimax-ai/minimax-bot/miniapp/node/mcp.mjs index 83610206..ed9da831 100644 --- a/plugins/minimax-ai/minimax-bot/miniapp/node/mcp.mjs +++ b/plugins/minimax-ai/minimax-bot/miniapp/node/mcp.mjs @@ -662,7 +662,7 @@ export function createMcpHandler({ team, engine }) { result = { protocolVersion: PROTOCOL_VERSIONS.includes(requested) ? requested : PROTOCOL_VERSIONS[0], capabilities: { tools: { listChanged: false } }, - serverInfo: { name: 'minimax-bot', version: '0.7.33' }, + serverInfo: { name: 'minimax-bot', version: '0.7.37' }, instructions: t('mcp.instructions'), }; break; diff --git a/plugins/minimax-ai/minimax-bot/package.json b/plugins/minimax-ai/minimax-bot/package.json index a4548754..c152016d 100644 --- a/plugins/minimax-ai/minimax-bot/package.json +++ b/plugins/minimax-ai/minimax-bot/package.json @@ -1,6 +1,6 @@ { "name": "minimax-bot", - "version": "0.7.33", + "version": "0.7.37", "private": true, "type": "module", "mcode": { diff --git a/plugins/minimax-ai/minimax-bot/tests/engine-reliability.test.mjs b/plugins/minimax-ai/minimax-bot/tests/engine-reliability.test.mjs index 1fafd72d..68bdaecc 100644 --- a/plugins/minimax-ai/minimax-bot/tests/engine-reliability.test.mjs +++ b/plugins/minimax-ai/minimax-bot/tests/engine-reliability.test.mjs @@ -1427,3 +1427,59 @@ test('stopping a helper while its admission is still being saved stops it for go assert.equal(store.state.helpers.find((helper) => helper.id === queued.id).status, 'stopped'); assert.equal(runs, 1); }); + +test('a group round whose members pass does not report a pass as its outcome', async (t) => { + const { store, engine } = await fixture(t); + const { a, chatId } = groupFixture(store); + // The only member to speak passes: the round produced nothing, so there is nothing to report. + engine.agent = { async run(input, options) { + return { ...started(input, options, 'pass-session'), status: 'finished', text: '[PASS]' }; + } }; + + const result = await engine.driveGroup(store.state.groups[0], [a.id], undefined); + + assert.equal(result.text, '', 'a round that only passed has no outcome to hand over'); + assert.doesNotMatch(String(result.text ?? ''), /PASS/i); + const messages = await store.getMessages(chatId); + assert.equal(messages.filter((message) => message.status === 'pass').length, 1, 'the pass is still recorded in the chat'); +}); + +test('a pass by the last speaker does not overwrite what an earlier one said', async (t) => { + const { store, engine } = await fixture(t); + const { a, b, chatId } = groupFixture(store); + store.state.groups[0].memberIds = [a.id, b.id]; + // Alice speaks, Bob adds nothing: the round's outcome is Alice's text, not Bob's pass. + engine.agent = { async run(input, options) { + const alice = input.text.includes("It's your turn (Alice)"); + return { ...started(input, options, alice ? 'a-session' : 'b-session'), status: 'finished', + text: alice ? '@Bob take a look' : '[PASS]' }; + } }; + + const result = await engine.driveGroup(store.state.groups[0], [a.id], undefined); + + assert.equal(result.text, '@Bob take a look'); + assert.doesNotMatch(String(result.text ?? ''), /PASS/i); + const messages = await store.getMessages(chatId); + assert.equal(messages.filter((message) => message.status === 'pass').length, 1); +}); + +for (const [flag, value] of [['waitingForTasks', true], ['safeToContinue', false]]) { + test(`a pass preserves the group stop when ${flag} is ${value}`, async (t) => { + const { store, engine } = await fixture(t); + const { a, b, group, chatId } = groupFixture(store); + const message = await store.appendMessage(chatId, { role: 'bot', botId: a.id, text: '[PASS]', status: 'done' }); + const speakers = []; + engine.runBotTurn = async ({ bot }) => { + speakers.push(bot.id); + return { status: 'done', accepted: true, text: '[PASS]', messageId: message.id, [flag]: value }; + }; + + const result = await engine.driveGroup(group, [a.id, b.id], undefined); + + assert.deepEqual(speakers, [a.id]); + assert.deepEqual(result.remaining, [b.id]); + assert.equal(result.messageId, message.id); + assert.deepEqual((await store.getMessages(chatId)).map((item) => item.status), ['done']); + assert.equal(result[flag], value); + }); +}